-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: Suggest user.email
to be 41898282+github-actions[bot]@users.noreply.github.com
#1184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To match squash merge user, else showing as two different users, see: SocketDev/socket-sdk-js@b0948d0
user.email
to be github-actions[bot]@users.noreply.github.com
user.email
to be 41898282+github-actions[bot]@users.noreply.github.com
DennisTsar
added a commit
to opLetter/course-evals
that referenced
this pull request
Apr 4, 2023
jeffwidman
added a commit
to dependabot/fetch-metadata
that referenced
this pull request
May 1, 2023
This is an aesthetic tweak to let the proper avatar show up: * https://github.com/orgs/community/discussions/26560 * actions/checkout#1184
jeffwidman
added a commit
to dependabot/fetch-metadata
that referenced
this pull request
May 2, 2023
This is an aesthetic tweak to let the proper avatar show up: * https://github.com/orgs/community/discussions/26560 * actions/checkout#1184
jeffwidman
added a commit
to github/dependabot-action
that referenced
this pull request
May 12, 2023
This is an aesthetic tweak to let the proper avatar show up: * https://github.com/orgs/community/discussions/26560 * actions/checkout#1184
jeffwidman
added a commit
to github/dependabot-action
that referenced
this pull request
May 12, 2023
This is an aesthetic tweak to let the proper avatar show up: * https://github.com/orgs/community/discussions/26560 * actions/checkout#1184
bananarama92
added a commit
to bananarama92/MBS
that referenced
this pull request
May 27, 2023
nullcoder
added a commit
to nullcoder/devcontainer-features
that referenced
this pull request
Jun 1, 2023
Update git user and email per actions/checkout#1184
nscuro
added a commit
to DependencyTrack/hyades
that referenced
this pull request
Aug 1, 2023
See actions/checkout#1184 Signed-off-by: nscuro <nscuro@protonmail.com>
mehab
pushed a commit
to DependencyTrack/hyades
that referenced
this pull request
Sep 12, 2023
See actions/checkout#1184 Signed-off-by: nscuro <nscuro@protonmail.com> Signed-off-by: mehab <meha.bhargava@citi.com>
@voxpelli : just want to thank you for opening this PR as I myself had the same question. I'm working to raise this up with the Actions team as I think it should be considered and merged 👍 |
Anything I can do to move this forward @cory-miller and others? |
itislu
added a commit
to itislu/42free
that referenced
this pull request
Apr 21, 2024
itislu
added a commit
to itislu/42free
that referenced
this pull request
Apr 21, 2024
2 tasks
I'm going to close this one out now that #1707 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get a proper GitHub Actions Bot annotation to a commit one should set the
user.name
anduser.email
to:There are some confusion around this in the
actions/
org itself:github-actions[bot]
+github-actions@github.com
which does not give a proper avatar on the commitgithub-actions[bot]
+github-actions[bot]@users.noreply.github.com
) apart from lacking the41898282+
prefix to the emailActions service account
+no-reply@github.com
(Another interesting aspect of the linked to workflows is that some use
--local
when setting the name and email, some use--global
and some does what is suggested here and use neither of--local
and--global
)Of note is also a third approach from the community, where it strives to achieve custom bot users (+ to get around the limitation of workflow created PR:s not running workflows): https://github.com/wow-actions/use-app-token Such a
env.BOT_NAME
would be quite nice to have built in to use.An example generated with this setup can be found here: SocketDev/socket-sdk-js@24f0574
Generated with: https://github.com/SocketDev/workflows/blob/24190c5ca3aa54b086ff1666ed4486f6bc1e9ec9/.github/workflows/reusable-sync.yml#L118-L119
EDIT: Swapped the recommendation to include the prefix
41898282+
as I found out that that's the email used when the bot does eg. squash commits and thus its otherwise showing up as being two different users, which looks a bit confusing. See eg: SocketDev/socket-sdk-js@b0948d0